search

ajhyndman / fire-emblem-working-title

A fledgling project wrangling Fire Emblem: Heroes stats
25 stars 6 forks source link

Fix Cargo table join queries and normalize dates to ISO 8601 format #127

Closed carsomyr closed 6 years ago

carsomyr commented 6 years ago

I finally got around to normalizing the dates to ISO 8601 format as well as fixing two Cargo table queries involving joins. The wiki seems to have stopped accepting fully qualified column names in the group_by clause.

ajhyndman commented 6 years ago

The wiki API keeps changing under our feet! 🙈 I should ask the maintainers if they can let me know when there's a change.

It looks like there are a couple brittle tests against the stats that are failing. If you want to just comment them out, I'll investigate and fix later.

carsomyr commented 6 years ago

@ajhyndman How do I go about running tests locally?

ajhyndman commented 6 years ago

@carsomyr It should be as easy as running yarn test in the package you want to test. You can also run yarn test from the root of the project to run all tests.

Let me know if you have issues with that. 😮

ajhyndman commented 6 years ago

@carsomyr I have the time, so I'll merge and fix up the tests now. Thanks for the PR!

carsomyr commented 6 years ago

@ajhyndman Awesome! If you're a frequent player like myself, feel free to add: My friend code is 6672452392. All that scraping and post-processing has gotta amount to something.

ajhyndman commented 6 years ago

@carsomyr Yeah, sure! You'd think this technical skill would amount to something more than tier 17, but I do play. I sent through a request.

carsomyr commented 6 years ago

@ajhyndman I don't think one's rank has anything to do with one's enjoyment of the game, which can be played in so many ways (Cargo table munging via functional programming in JavaScript included; I learned a lot from your code). In fact, I would say that you're indirectly responsible for me building up a +9 Myrrh. (Guess whose stats.json file helped me generate a spreadsheet of heroes and banner probabilities, save up 1100 orbs, and color snipe green?)

ajhyndman commented 6 years ago

Haha, cool! I confess, I haven't really looked at your spreadsheet too closely, nor do I know how to make sense of it. You've got some serious spreadsheet scripting at work in there.

What drove you to save up 1100 orbs?!

Would you care to connect via a medium a little more conducive to conversation? 😛 Perhaps Discord? My discord ID is **.

carsomyr commented 6 years ago

@ajhyndman Added!