search

ajilo297 / Flutter-Dotted-Border

A Flutter package to easily add dashed borders around widgets
https://pub.dev/packages/dotted_border
MIT License
297 stars 62 forks source link

Provide a means to override StackFit.loose #28

Closed lclaesen closed 1 year ago

lclaesen commented 1 year ago

A big thanks for your package: it saved us the time and trouble of having to develop a custom border ourselves.

It would greatly improve the usability of your widget, if it would allow to control the constraints that DottedBorder would pass to its child widget. Currently, the inner stack always loosens the constraints passed to the child (the default value of Stack.fit); that might be what some of the users want, but certainly not wat all of them want to happen. In our particular case, we want DottedBorder.child to respect a minimal height imposed on the DottedBorder widget itself -- something that the Stack allows by setting it's fit property to StackFit.passthrough.

ajilo297 commented 1 year ago

This should be fixed by 2cd8eca89a7e779cc22af6278550b8541438386f

lclaesen commented 1 year ago

Thanks a lot, @ajilo297. Works like a charm.