search

ajitid / fzf-for-js

Do fuzzy matching using FZF algorithm in JavaScript
https://fzf.netlify.app
BSD 3-Clause "New" or "Revised" License
883 stars 22 forks source link

build: add windows compat layer in scripts #90

Closed ajitid closed 2 years ago

ajitid commented 2 years ago

Before this PR, on Windows when one builds and serves the docs, they couldn't see docs for the older versions. This used to happen because shelljs in Windows runs command prompt, which requires more parts of the command string to be wrapped in double quotes.

This PR tries to achieve the above without adding maintenance burden. It is able to do so by copying scripts and making necessary changes for them to run on Windows. While it sounds counter to what we are trying to achieve, this decision seems correct as a readable code is a maintainable one.

This PR also upgrades pipeline Node.js version to v16 which also makes this PR a continuation of https://github.com/ajitid/fzf-for-js/pull/89.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for fzf ready!

🔨 Explore the source changes: f7f3e2abe0a5b6177ace144a9d16e1ba7b22085c

🔍 Inspect the deploy log: https://app.netlify.com/sites/fzf/deploys/617b270f0207410008ff8431

😎 Browse the preview: https://deploy-preview-90--fzf.netlify.app/