search

ajitsinghkaler / devto-clone

This is a dev to clone in angular. Where we used Angular component-store, rx-angular/template
https://dev-toclone.firebaseapp.com/
MIT License
39 stars 11 forks source link

Add listing pages and masonary layout #11

Closed ChellappanRajan closed 3 years ago

ChellappanRajan commented 3 years ago

This is my first commit for listing page still lot of works are pending. Since there is lot of changes, planned to raise incremental PR to make review easy.

ajitsinghkaler commented 3 years ago

Let me know when its available for a review

ChellappanRajan commented 3 years ago

Let me know when its available for a review

Hi @ajitsinghkaler can you please review the changes that I have pushed so far?

ajitsinghkaler commented 3 years ago

I'll have a look on Thursdays only I only Have time on Thursdays

ajitsinghkaler commented 3 years ago

Hi @ChellappanRajan I've left my review

ChellappanRajan commented 3 years ago

Hi @ajitsinghkaler Currently listings API does not returns created_at property as mentioned in the docs . As a workaround currently I am using https://dev.to/search/ end Point.

ajitsinghkaler commented 3 years ago

Go ahead.

ChellappanRajan commented 3 years ago

Go ahead.

Can you please review my new changes. If everything okay then you can merge this change. Remaing Part like dropdown, paginatin. I will create new PR.

ajitsinghkaler commented 3 years ago

Can you tell me which drop down you are referring to

ajitsinghkaler commented 3 years ago

Can you also create a issue so that we can keep track of what all is left in this

ChellappanRajan commented 3 years ago

Can you also create a issue so that we can keep track of what all is left in this

Yes sure wil do that

ajitsinghkaler commented 3 years ago

Everything is looking fine just a few comments and we need how you implemented the masonry layout