search

ajitsinghkaler / devto-clone

This is a dev to clone in angular. Where we used Angular component-store, rx-angular/template
https://dev-toclone.firebaseapp.com/
MIT License
39 stars 11 forks source link

Content projection header #3

Open ajitsinghkaler opened 3 years ago

ajitsinghkaler commented 3 years ago

Content projection header in article card seems too much shouldn't we use an input param which defines the size of the title of the card and if there is no size given use default title size.

NsdHSO commented 2 years ago

@ajitsinghkaler @ChellappanRajan I want you to assign the this me.

ajitsinghkaler commented 2 years ago

Assigned it to you

NsdHSO commented 2 years ago

Here I not see anything ng-projection ( In component of the header ), please be more specific

ajitsinghkaler commented 2 years ago

Its in article-card.component

https://github.com/ajitsinghkaler/devto-clone/blob/main/libs/global-components/src/lib/article-card/article-card.component.html#L17-L24

NsdHSO commented 2 years ago

@ajitsinghkaler What more exactly do I have to do ?

ajitsinghkaler commented 2 years ago

Here I don't like the way I've implemented it in *ngIf="!ref.hasChildNodes()" I want to change it is there a better structure

NsdHSO commented 2 years ago

ok, I take a time, and I try to resolved