search

ajiwo / xiboside

Xibo Player
GNU Affero General Public License v3.0
10 stars 7 forks source link

Code review #2

Closed miolion closed 7 years ago

miolion commented 7 years ago

To pass zindex from CMS to xiboside. To avoid MemError exception when downloading if there are big size of video files from CMS.

ajiwo commented 7 years ago

Could you please make it a bit tidier by putting the 1024*1024*2 constant into a variable, maybe I'd like to make it configurable at some point later.

miolion commented 7 years ago

It was just a pull request for your code review of minimal changes from the original code to point out the issue so that you can modify and merge them as you wish. Yes, we'd better make it configurable and remove any redundant codes.

ajiwo commented 7 years ago

Alright then, we can tidy it up later.