ajjNV5 / Potential-Study-Tool

NV5 Demand Side Management Interactive Tool
0 stars 1 forks source link

change hard-coded line numbers in combine_measure_sheets_test function #15

Open mcfink-NV5 opened 3 months ago

mcfink-NV5 commented 3 months ago

This is in reference to lines in the combine_measure_sheets_test function like this:

df_measure = pd.read_excel(file_path, sheet_name=sheet_name, skiprows=31, nrows=18)

Based on the fluidity of the input sheets that we're bound to get that incorporate measures, I'm worried that identifying where (for example) the 'df_measures' part of the spreadsheet starts by how many rows down it is and how many rows long it is will be problematic -- someone is going to scoot everything down a row and it's going to wreck everything!

I don't have a good solution for this yet... I think we should talk about this and come up with some sort of strict format that has landmarks that we'll be able to pick out from inside python that allows for users to change row numbers, but also lets us be certain that we're picking up exactly the correct rows for the dataframes that we need.