search

ajjahn / puppet-dhcp

Module for provisioning Internet Systems Consortium DHCP Server (dhcpd)
3 stars 9 forks source link

Test ajjahn/dhcp with Puppet 4 #7

Open rnelson0 opened 8 years ago

rnelson0 commented 8 years ago

When testing with Puppet 4 in a controlrepo, errors are found: https://travis-ci.com/rnelson0/controlrepo/jobs/27990879#L1289

Add Puppet 4 to the test matrix and start resolving issues.

ajjahn commented 8 years ago

@rnelson0 I'd welcome any contributions to get this up and running.

rnelson0 commented 8 years ago

Would you be willing to enable Travis CI integration on this repo? If you enable it, I will be glad to update .travis.yml with the newer versions and then submit some PRs to fix any errors found. I started that work here https://github.com/rnelson0/puppet-dhcp/tree/travisversions

ajjahn commented 8 years ago

@rnelson0 I'm not sure I follow you. Travis is enabled here: https://travis-ci.org/ajjahn/puppet-dhcp. What am I missing?

rnelson0 commented 8 years ago

Hrm, I didn't think I saw it on past PRs, my bad. Anyway, PRs will be incoming then!

Rob Nelson rnelson0@gmail.com

rnelson0 commented 8 years ago

In the meantime, what are your thoughts on reducing the test matrix? IMO, Ruby 1.8.7 could easily be dropped, it's not supported by any current distro that I am aware of, that would knock a quarter of the matrix out. It's a more difficult question about dropping older puppet 3 versions but I think <3.5.0 could be dropped with minuscule impact.

ajjahn commented 8 years ago

Yeah, I'm okay with dropping 1.8.7. Let's keep <3.5.0 for now.