search

ajjahn / puppet-dhcp

Module for provisioning Internet Systems Consortium DHCP Server (dhcpd)
3 stars 9 forks source link

P4 fixes #9

Closed rnelson0 closed 8 years ago

rnelson0 commented 8 years ago

There was no dhcp::server::subnet test. I added a basic one and it passes now. It may need enhancement.

rnelson0 commented 8 years ago

@ajjahn This is passing and looks good to me. Would you rather move the 4.x tests out of allow_failures in this PR or in a separate PR?

Also, I think it might be time to bump the version number significantly, perhaps to 1.0.0?

ajjahn commented 8 years ago

@rnelson0 This PR was/is fine. Also, version is now bumped: 658308a.

rnelson0 commented 8 years ago

Sweet, looking forward to seeing it on the forge soon! Thanks!