search

ajjahn / puppet-dns

Module for provisioning DNS (bind9)
45 stars 112 forks source link

Fix breaking tests on old puppet and ruby #215

Closed ghost closed 7 years ago

ghost commented 7 years ago

Restrict puppetlabs-concat version to < 2.2.1

The puppetlabs-concat module version 2.2.1 (just released) introduces a breaking change for Puppet < 3.2.0: it includes the use of Puppet::Parameter::Boolean for type checking, but those parameter types were not introduced until 3.2.0.

Restrict puppetlabs_spec_helper gem version to < 2.1.1

puppetlabs_spec_helper gem version 2.1.1 introduces a dependency on the parallel gem, which requires Ruby 2.0. This breaks all testing on older Ruby versions.

ghost commented 7 years ago

FYI, MODULES-4687 submitted against puppetlabs-concat breaking change, and MODULES-4688 submitted against puppetlabs_spec_helper breaking change.