search

ajjahn / puppet-dns

Module for provisioning DNS (bind9)
45 stars 112 forks source link

Concat is a very old version #245

Open witchbutter opened 6 years ago

witchbutter commented 6 years ago

When installing this module indepently of a library Puppetfile, these are the versions that install:

/etc/puppetlabs/code/environments/production/modules
├── ajjahn-dns (v2.1.0)
├── puppetlabs-concat (v2.2.1)
└── puppetlabs-stdlib (v4.24.0)

The current version of concat is 4.1.1 and is incompatible. So where test code will work in a standalone vagrant box, if you try to integrate it into a control repo it will throw errors during manifest compile like so:

Error: Evaluation Error: Error while evaluating a Resource Statement, Concat::Fragment[named.conf.local.tsig.dynamic-update.include]: has no parameter named 'ensure' at /etc/puppetlabs/code/environments/production/modules/dns/manifests/tsig.pp:31 on node vagrant-ubuntu-trusty-64.somedomain.com

This version of concat is so far behind that this module isn't really possible to use in combination with newer modules that have already updated.

felixdoerre commented 6 years ago

It looks like there is already a fix for this issue (6145d61c13847aa24a5c01328cb4eaf75df4ec9a) but it didn't manage to get in a release yet.

witchbutter commented 6 years ago

Any plans to release soon?