search

ajkhoury / SigMaker-x64

IDA Pro 7 compatible SigMaker plugin
537 stars 88 forks source link

Make the cancel button work #24

Open Caraxi opened 3 years ago

Caraxi commented 3 years ago

Cancel search when the cancel button is pressed.

Caraxi commented 2 years ago

Any updates?

ajkhoury commented 2 years ago

Maybe I am misinterpreting the code, but what is the point of the extra or in cancelled = cancelled || user_cancelled(); ? Could you not simply do cancelled = user_cancelled();? Or better yet something like the following?

 if (user_cancelled()) {
    cancelled = true;
    break;
}
Caraxi commented 2 years ago

I don't remember why I did it like that