search

ajmal744 / google-api-dotnet-client

Automatically exported from code.google.com/p/google-api-dotnet-client
Apache License 2.0
0 stars 0 forks source link

RequestAccessToken should be public #420

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On ServiceAccountUserCredential the follow method should be public:

 private async Task<bool> RequestAccessToken(CancellationToken taskCancellationToken)

Original issue reported on code.google.com by pele...@google.com on 30 Nov 2013 at 3:24

GoogleCodeExporter commented 9 years ago 
Consider also 
https://code.google.com/p/google-api-dotnet-client/source/browse/Src/GoogleApis.
Auth/OAuth2/UserCredential.cs#51 changing the setter to be public or provide a 
clean method (that set TokenResponse to null and delete the token from the store

Original comment by pele...@google.com on 3 Dec 2013 at 5:05

GoogleCodeExporter commented 9 years ago

Original comment by pele...@google.com on 4 Dec 2013 at 9:58

GoogleCodeExporter commented 9 years ago 
It was decided that UserCredential won't contain clean method. We should just 
create a new class (although it isn't the best solution it makes the code 
easier to maintain and it's not a heavy weighted operation)

Original comment by pele...@google.com on 4 Dec 2013 at 10:05

GoogleCodeExporter commented 9 years ago 
both RefreshTokenAsync and RequestAccessTokenAsync (in UserCredential and 
ServiceAccountCredential are public now)

Original comment by pele...@google.com on 4 Dec 2013 at 10:06

GoogleCodeExporter commented 9 years ago 
https://codereview.appspot.com/37410043/

Original comment by pele...@google.com on 4 Dec 2013 at 10:09