search

ajmath / serverless-offline-scheduler

MIT License
96 stars 40 forks source link

Use rule name when specified #20

Closed zoellner closed 5 years ago

zoellner commented 5 years ago

Serverless allows to specify the rule name. This PR makes serverless-offline-scheduler use that rule name in the resources arn in order to better reflect the live AWS behavior. Closes #19

zoellner commented 5 years ago

Tests work fine locally. Is there really a need to support node 4.x? It reached End-of-Life almost a year ago, so explicitly not supporting it would be more secure at this point.

ajmath commented 5 years ago

Thanks for the PR! Can you please update the code to match the existing style used by the rest of the app with respect to the destructing? I realize that node 4 is overkill at this point but that should be taken care of in a separate PR.

zoellner commented 5 years ago

it's valid according to the eslint configuration you added to the project. If you'd like a different style, please update the eslint config and I'll see about updating the PR.

ajmath commented 5 years ago

Please just fix the tests