search

ajmath / serverless-offline-scheduler

MIT License
96 stars 40 forks source link

fix child process hanging on unclosed connections #46

Open jkruse14 opened 4 years ago

jkruse14 commented 4 years ago

I got rid of child_process and call the function directly because this allows you to set breakpoints and debug the scheduled task lambda.

jkruse14 commented 4 years ago

@ajmath - what are your thoughts on this update?

ajmath commented 4 years ago

@jkruse14 First and foremost, thanks for the PR and apologies for not getting back to you sooner.

So the behavior you're adding is actually the way this plugin worked before #22 which allows it to function with non javascript languages. I would suggest that we only try invoking the function directly when the plugin is running in a node serverless project and fallback to shelling out to support non javascript projects.