tweaks to Matt's PR to block adding quote token above auction price - Githubissues

ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

tweaks to Matt's PR to block adding quote token above auction price #1000

Closed EdNoepel closed 11 months ago

EdNoepel commented 11 months ago

Description

Code optimization

Purpose

Prevent double SafeCast and double assignment to struct, reducing gas cost.
Move _priceAt calls into the reverts helper, for tiny reduction in contract size.

Impact

Reduction in gas cost.

Tasks

[ ] Changes to protocol contracts are covered by unit tests executed by CI.
[ ] Protocol contract size limits have not been exceeded.
[ ] Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
[ ] Scope labels have been assigned as appropriate.
[ ] Invariant tests have been manually executed as appropriate for the nature of the change.