Contract size mitigation - Githubissues

ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Contract size mitigation #1004

Closed EdNoepel closed 11 months ago

EdNoepel commented 11 months ago

Description

Moved some things around to get ERC721Pool to fit within contract size boundaries.

Moved debtInfo logic into PoolCommons, saving 10 bytes.
Moved withdrawBonds into KickerActions library, saving 46 bytes (h/t @MikeHathaway)

Since a max amount is passed as a parameter, withdrawBonds now returns the actual amount withdrawn, consistent with other methods.

Purpose

We cannot deploy if max contract size is exceeded.
Integrators want actual values returned when they call a method with uint256.max.

Impact

Additional gas consumption:

median ERC20Pool debtInfo cost went from 5784 to 7756
median ERC20Pool withdrawBonds cost went from 10045 to 10784

Considered reverting the debtInfo change, but we're still quite close to the size limit.

Tasks

[x] Changes to protocol contracts are covered by unit tests executed by CI.
[x] Protocol contract size limits have not been exceeded.
[x] Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
[ ] Scope labels have been assigned as appropriate.
[ ] Invariant tests have been manually executed as appropriate for the nature of the change.