Remove unused vars (Kirill I-18) - Githubissues

ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Remove unused vars (Kirill I-18) #1023

Closed EdNoepel closed 11 months ago

EdNoepel commented 11 months ago

Description

Remove unused varables to resolve Kirill I-18.

Purpose

Improve maintainability of the code.

Impact

No impact was expected on pool contracts, but it actually decreased size of ERC20Pool from 23,609B (96.06%) to 23,599B (96.02%).

Tasks

[x] Changes to protocol contracts are covered by unit tests executed by CI.
[x] Protocol contract size limits have not been exceeded.
[ ] Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
[x] Scope labels have been assigned as appropriate.
[ ] Invariant tests have been manually executed as appropriate for the nature of the change.