The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.
Adds tests of event emission to ERC721 pool creation.
Purpose
subsetHash is a required parameter for pool lookup in the factory. For non-subset pools, this subsetHash can be obtained from the factory constant, but for ERC721 subset pools this value is calculated in the deploy function and not emitted or returned. Emitting the subsetHash in the event will allow integrators to get the hash from the event and use it for pool lookups without needing to inspect the transaction inputs and recalculating the value.
Impact
Slight gas increase for the additional event parameter on pool deploy.
Tasks
[ ] Changes to protocol contracts are covered by unit tests executed by CI.
[ ] Protocol contract size limits have not been exceeded.
[ ] Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
[ ] Scope labels have been assigned as appropriate.
[ ] Invariant tests have been manually executed as appropriate for the nature of the change.
Description
Updated to target
developfrom #1012Adds subsetHash to PoolCreated event.
Adds tests of event emission to ERC721 pool creation.
Purpose
subsetHashis a required parameter for pool lookup in the factory. For non-subset pools, this subsetHash can be obtained from the factory constant, but for ERC721 subset pools this value is calculated in the deploy function and not emitted or returned. Emitting the subsetHash in the event will allow integrators to get the hash from the event and use it for pool lookups without needing to inspect the transaction inputs and recalculating the value.Impact
Slight gas increase for the additional event parameter on pool deploy.
Tasks