Closed MikeHathaway closed 11 months ago
Commit 9fd555c removes
ERC20PoolPositionHandler
and regression tests, which I spent substantial effort making operational.
Apologies @EdNoepel , didn't take the time to review "why" you made the changes. Your changes successfully resolved test_regression_index_out_of_bounds()
and test_regression_max_less_than_min()
. I added them again in this commit -> https://github.com/ajna-finance/contracts/pull/1041/commits/3a63048a77a381449fabc84c1175b6c8a677aeed
I prefer to be consistent in naming, that is rename
Positions
directories in tests toPositionManager
(to matchERC20Pool
andERC721Pool
namings)
Resolved -> https://github.com/ajna-finance/contracts/pull/1041/commits/3a63048a77a381449fabc84c1175b6c8a677aeed
Description
RewardsManager.sol
and all respective testsPurpose
During our Sherlock and Kiril audits there was a bug discovered in
RewardsManager.sol
. Although we had previously agreed not to deploy the contract prior to the audit, having a implementation example with a bug is a bad idea. We opted to removeRewardsManager.sol
all together in the event someone used it.Impact
Tasks