Fix slither CI - install forge in flow to compile - Githubissues

ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Fix slither CI - install forge in flow to compile #1051

Closed grandizzy closed 10 months ago

grandizzy commented 11 months ago

Description

slither detect now if foundry project and compiles it using forge. install foundry in slither job to make compilation possible
fix path to external libraries dir
remove unused IERC20Token.transfer* functions (as safeTransfer* are used for ERC20) to solve https://github.com/crytic/slither/wiki/Detector-Documentation#incorrect-erc20-interface warnings

Purpose

Impact

Tasks

[ ] Changes to protocol contracts are covered by unit tests executed by CI.
[ ] Protocol contract size limits have not been exceeded.
[ ] Gas consumption for impacted transactions have been compared with the target branch, and nontrivial changes cited in the Impact section above.
[ ] Scope labels have been assigned as appropriate.
[ ] Invariant tests have been manually executed as appropriate for the nature of the change.