ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Prototech 21: Gas Optimization: `bytes32ToString` can be improved to reduce gas costs #860

Closed prateek105 closed 1 year ago

prateek105 commented 1 year ago

Description of change

High level

See - https://github.com/Fixed-Point-Solutions/prototech-ajna-audit/issues/21
Use mstore to make trimming array gas efficient.

prateek105 commented 1 year ago

LGTM. That being said, gas costs really aren't a concern here as this is only ever used as part of view functions that should only be called off-chain. Yes, right. updated this just in case this method is called from a contract. very low priority.