Sherlock-88: In `moveQuoteToken` ensure pool debt is less than deposits (if deposit fee applied)

[grandizzy]

Description of change

High level

• see https://github.com/sherlock-audit/2023-04-ajna-judging/issues/88
• moveQuoteToken doesn't check if pool debt is not less than deposits
  • in removeQuoteToken after removing amount from deposit we revert if HTP > LUP or pool debt exceeds deposits
  • in moveQuoteToken we revert if HTP > LUP but don't check if pool debt exceeds deposits (unlikely but there's a chance when unutilized deposit fee is applied)
  • fixed by checking that, after move quote token, the pool debt doesn't exceed deposits

Contract size

Pre Change

 LenderActions            -  10,603B  (43.14%)

Post Change

LenderActions            -  10,635B  (43.27%)

Gas usage

Pre Change

| moveQuoteToken                       | 847             | 143618 | 102184 | 632650 | 24      |
| moveQuoteToken                         | 40229           | 40326  | 40330  | 40417    | 4       |

Post Change

| moveQuoteToken                       | 847             | 137806 | 102184 | 632831 | 24      |
| moveQuoteToken                         | 40229           | 40326  | 40330  | 40417    | 4       |

[grandizzy]

lgtm (although I think the name of the PR is reversed -- we are ensuring that the debt is less than the deposit)

thanks, makes sense, I updated it

[grandizzy]

This PR appropriately restricts the HTP from being above the LUP && the debt exceeding deposit if a lender moves from a higher index to a lower index.

I suggest we add a simple test which proves this functionality is working as expected

yep, makes sense! mind to add such to existing PR? @ith-harvey

[grandizzy]

LGTM

The links that summarize the issue may die... please copy and paste the issue into the description directly

updated