ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Invariants Improvement: Add multiple pool support in position and rewards manager invariant testing #927

Closed prateek105 closed 1 year ago

prateek105 commented 1 year ago

Description of change

High level

Contracts

In rewardsManager, rewardsClaimedand updateRewardsClaimed were stored per epoch https://github.com/ajna-finance/contracts/blob/develop/src/RewardsManager.sol#L71. Since we can have multiple pools so rewardsClaimed should be stored per pool per epoch rather than only per epoch.
Fixed with storing rewardsClaimedand updateRewardsClaimed per pool per epoch.

Invariants

Updated Position and rewards Manager invariants to test against multiple pools.
Add configurable NO_OF_POOLS env var for position and rewards manager

prateek105 commented 1 year ago

@dmitriia Added gas improvements as per your comment here https://github.com/ajna-finance/contracts/pull/929. I have not updated the comments for consistency in the rest of the code.

dmitriia commented 1 year ago

Looks ok