ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.

https://www.ajna.finance/

Other

31 stars 11 forks source link

Invariants Improvements: Add Multiple position in single handler in Position #928

Closed prateek105 closed 1 year ago

prateek105 commented 1 year ago

Description of change

High level

Add ability for position manager invariant handler to memorialize and redeem multiple positions in a single handler call.
Update redeem position handler to redeem partial positions.
Add random time skip (15 days to 30 days) between epochs in rewards manager invariant setup.

MikeHathaway commented 1 year ago

LGTM - would suggest also ensuring a variable number of indexes are used in the other PM and RM methods.

prateek105 commented 1 year ago

I think we should remove hardcoding to 1 bucket at a time, and add support for variable numbers of buckets in moveLiquidity

while working on this i realised that the contract does not support moving of multiple positions in a single call, so i don't think that this would be useful in this scenario.

MikeHathaway commented 1 year ago

I think we should remove hardcoding to 1 bucket at a time, and add support for variable numbers of buckets in moveLiquidity

while working on this i realised that the contract does not support moving of multiple positions in a single call, so i don't think that this would be useful in this scenario.

Good point - ok with merging as is then