search

ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.
https://www.ajna.finance/
Other
31 stars 11 forks source link

Merge Develop into Master #934

Closed ith-harvey closed 1 year ago

EdNoepel commented 1 year ago

In PR#927, dmitriia stated this Looks ok. How do we confirm that constitutes acceptance that merging this will not invalidate Sherlock inusrance?

ith-harvey commented 1 year ago

In PR#927, dmitriia stated this Looks ok. How do we confirm that constitutes acceptance that merging this will not invalidate Sherlock inusrance?

As per the conversation in the Sherlock Discord, dmitriia gave his consent to this change, which is proof insurance is supported.

@ithharvey
So the “process” just so I’m aware is getting dmitry’s buy off essentially. 
...
@MaijaLee
Yes, we look for the Lead Senior Watson's sign-off that the fix looks good.
...
@jack
^I see hyh gave a thumbs up to the message above so it seems like he is in accordance with this

@hyh (dmitriia)
Yes, it looks ok. It's about 50 lines in the core contract