ajna-finance / ajna-core

The Ajna protocol is a non-custodial, peer-to-peer, permissionless lending, borrowing and trading system that requires no governance or external price feeds to function.
https://www.ajna.finance/
Other
31 stars 11 forks source link

Revert CRA kick if a liquidation awaits settlement #977

Closed EdNoepel closed 1 year ago

EdNoepel commented 1 year ago

Description

Prevent kicking a Claimable Reserve Auction (CRA) if a liquidation auction is pending settlement.

Purpose

Impact

Expect small gas cost in kickReserveAuction and increase in contract size. Specifically, ERC721Pool size increased from 98.97% to 99.02%. ERC721 unit tests were unchanged, and median gas for the call increased from 64977 to 67372.

Tasks

EdNoepel commented 1 year ago

Investigating regression test breakage. The affected test does not involve a reserve auction.

EdNoepel commented 1 year ago

I had been investigating a baffling regression test failure. After doing a foundryup I was unable to reproduce the behavior. Reran CI job a second time and the problem went away.

MikeHathaway commented 1 year ago

Is this attack still feasible with the removal of reserves covering bad debt?