🐛 Walkx icon repository not using updates files - API

[ajnart]

Environment

Docker

Version

No response

Describe the problem

@walk icon repository has now SVG icons, he spent a lot of time on it and they don’t seem to appear in homarr. I’m not sure why I’ve tried to look at it in the code but couldn’t really figure how it works.

ill assign this to you @manuel-rw since you did the icon picker component and all the logic with that ;)

Logs

No response

Context

No response

Please tick the boxes

• [X] I confirm that I attached the proper logs
• [X] I've read the docs
• [X] I've checked for duplicate issues
• [X] I've tried to debug myself

[manuel-rw]

Sure. I'll look into it. Thanks for assigning

[manuel-rw]

Ok, so this is what's going on:

The API route https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@master?structure=flat returns the following item in the flat file list:

{
        "name": "/png/alpine-linux.png",
        "hash": "F2lnsPbJo2gph4hwkNwnKRBhdMsJs1jPJ2SVt68zdwQ=",
        "size": 22073
},

However, this file does not exist on the CDN data endpoint: https://cdn.jsdelivr.net/gh/walkxcode/dashboard-icons@master/png/alpine-linux.png :

Couldn't find the requested file /png/alpine-linux.png in walkxcode/dashboard-icons.

Other files, like the following work on both endpoints:

• homarr.svg
• homarr.png
• alpine.png

I don't get it, why this is happening. I double checked that we request the correct branch, that there is no caching going on and that it's not my device / network being the traitor. @walkxcode can you maybe assist us on this issue?

[walkxcode]

https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@master?structure=flat > https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@main?structure=flat :)

This actually doesn't work?.. I'll look further into the issue.

[ajnart]

~https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@master?structure=flat > https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@main?structure=flat :)~

This actually doesn't work?.. I'll look further into the issue.

So there’s no way of getting the up to date files ? 💀

[walkxcode]

There is. I just read that jsDelivr switched to a system where anything after the @ will be the NPM version tag. Problem is... There is no NPM in my project :') I'm going to try some possible fixes, and otherwise I might have to find another CDN (old CDN will still work no problem).

[ajnart]

@walkxcode your main branch is called “main” not “master” anymore. Maybe that’s the issue with the jsdelivr?

[walkxcode]

No. I've tried.

[walkxcode]

~data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@master?structure=flat > data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@main?structure=flat :)~ This actually doesn't work?.. I'll look further into the issue.

So there’s no way of getting the up to date files ? 💀

Yeah, I don't think it's possible...

[manuel-rw]

Does master maybe reference the first ever recorded version of the branch but not updates afterwards? If that's the case, we would have to tag a specific version instead of using master / main (eg. a commit hash). We could retrieve the latest commit hash via API and then retrieve the contents of that specific revision. Kind of breaks image caching, but probably our best bet?

[walkxcode]

I think that's the case, but I don't know if commit hashes will work.

[manuel-rw]

They do. It's documented in the docs. However, we need to know the hashes in the first place...

It's also weird that this issue only seems to exist for your icon repo.The other work fine.

[ajnart]

They do. It's documented in the docs. However, we need to know the hashes in the first place...

It's also weird that this issue only seems to exist for your icon repo.The other work fine.

Why not just use main and use the latest one ? The only issue is that the branch got renamed and the CDN didnt pick it up to alias it to main instead of master. replacing it with main should work.

[walkxcode]

No. It does not work, as I already said above.

[manuel-rw]

I can confirm that main doesn't work either.

[manuel-rw]

This API endpoint is working for me:

https://data.jsdelivr.com/v1/packages/gh/walkxcode/dashboard-icons@118c204a1c84245c98ec316e1918f42277d68248?structure=flat

{
        "name": "/png/alpine.png", // <-- correct file name, that was updated recently, as an example
        "hash": "okx+Xqqc45mGtY1o3GgZzTU+HBSnTKF9ybnpj5O/Ypw=",
        "size": 18264
}

[ajnart]

We could try to email jsdelivr to ask them how to get the link to the latest resources, it might be a bug on their end or something we weren’t able to find about online

[manuel-rw]

Interestingly, JsDelivr seems to "know" no versions:

[manuel-rw]

At least JsDelivr seems to know the project:

curl -X GET "https://data.jsdelivr.com/v1/stats/packages/gh/walkxcode/dashboard-icons?period=week" \
 -H "accept: application/json" \

{
  "hits": {
    "rank": 817,
    "typeRank": 273,
    "total": 2077449,
    "dates": {
      "2022-10-15": 311693,
      "2022-10-16": 334698,
      "2022-10-17": 283700,
      "2022-10-18": 266822,
      "2022-10-19": 263361,
      "2022-10-20": 319285,
      "2022-10-21": 297890
    },
    "prev": {
      "rank": 819,
      "typeRank": 269,
      "total": 2038555
    }
  },
  "bandwidth": {
    "rank": 1174,
    "typeRank": 608,
    "total": 33431191086,
    "dates": {
      "2022-10-15": 5148082281,
      "2022-10-16": 5449361001,
      "2022-10-17": 4642068503,
      "2022-10-18": 4460342994,
      "2022-10-19": 4497136347,
      "2022-10-20": 4590028290,
      "2022-10-21": 4644171670
    },
    "prev": {
      "rank": 1160,
      "typeRank": 607,
      "total": 34557768886
    }
  },
  "links": {
    "self": "https://data.jsdelivr.com/v1/stats/packages/gh/twbs/bootstrap?period=week",
    "versions": "https://data.jsdelivr.com/v1/stats/packages/gh/twbs/bootstrap/versions?period=week"
  }
}

[ajnart]

At least JsDelivr seems to know the project:

curl -X GET "https://data.jsdelivr.com/v1/stats/packages/gh/walkxcode/dashboard-icons?period=week" \
 -H "accept: application/json" \

{
  "hits": {
    "rank": 817,
    "typeRank": 273,
    "total": 2077449,
    "dates": {
      "2022-10-15": 311693,
      "2022-10-16": 334698,
      "2022-10-17": 283700,
      "2022-10-18": 266822,
      "2022-10-19": 263361,
      "2022-10-20": 319285,
      "2022-10-21": 297890
    },
    "prev": {
      "rank": 819,
      "typeRank": 269,
      "total": 2038555
    }
  },
  "bandwidth": {
    "rank": 1174,
    "typeRank": 608,
    "total": 33431191086,
    "dates": {
      "2022-10-15": 5148082281,
      "2022-10-16": 5449361001,
      "2022-10-17": 4642068503,
      "2022-10-18": 4460342994,
      "2022-10-19": 4497136347,
      "2022-10-20": 4590028290,
      "2022-10-21": 4644171670
    },
    "prev": {
      "rank": 1160,
      "typeRank": 607,
      "total": 34557768886
    }
  },
  "links": {
    "self": "https://data.jsdelivr.com/v1/stats/packages/gh/twbs/bootstrap?period=week",
    "versions": "https://data.jsdelivr.com/v1/stats/packages/gh/twbs/bootstrap/versions?period=week"
  }
}

But why are the dates so far in time ?

[manuel-rw]

According to https://github.com/jsdelivr/jsdelivr/issues/18417#issuecomment-1163078689 , it should update within 12 hours. I tried purging the cache using https://purge.jsdelivr.net/walkxcode/dashboard-icons@main, but that didn't change anything (or it takes longer to propagate to the CDN). https://github.com/video-dev/hls.js/issues/1664#issuecomment-380941077

https://stackoverflow.com/a/69151200

Maybe we need to wait now? 🤔

Related to https://github.com/mavoweb/mavo/issues/603

[ajnart]

Is this still an issue ? Im not sure

[walkxcode]

Yes it is

[walkxcode]

https://api.github.com/repos/walkxcode/dashboard-icons/git/trees/main?recursive=true

[ajnart]

Fixed with #1520