ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.5k stars 255 forks source link

Fetch bookmark icons automatically... #1338

Open Jaxel opened 10 months ago

Jaxel commented 10 months ago

Description

When you input a URL for a bookmark, you have to manually assign an image for the icon.

It would be convenient if at first, the system fetched the source of that URL and looked for <link rel="icon" or <link rel="apple-touch-icon" to find the default icon for that bookmark. If no icons are find, try to fetch /favicon.ico automatically.

Priority

Low (Nice-to-have)

ajnart commented 10 months ago

I’m not exactly sure how we can do that. But I believe we could implement that. Although the favicons are usually 16x16 so it would look terrible when increased to your app icon.

Can you send me a direct example of that ? Like example page, and header data linking to the app’s icon. Also maybe some websites will have relative paths idk how to handle that (icon = ./public/icon.ico)

Jaxel commented 10 months ago

That's why I said favicons used be used as a fallback; only if an icon or apple-touch-icon are not found.

You can easily cURL the bookmarked page, and then run a regex for the icons.

manuel-rw commented 5 months ago

Related with #1694