search

ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.52k stars 255 forks source link

Add OMV integration / widget #1879

Closed hillaliy closed 4 months ago

hillaliy commented 5 months ago

Category

Feature

Screenshot (if applicable)

Screenshot 2024-02-02 at 13 37 58
hillaliy commented 4 months ago

Hi @Tagaishi , I think you were right from the beginning, it is necessary to create a widget that will display data directly from the operating system and not from a certain integration

SeDemal commented 4 months ago

Hi @Tagaishi , I think you were right from the beginning, it is necessary to create a widget that will display data directly from the operating system and not from a certain integration

Actually the idea that somenoperating system offer more monitoring through their API could be something interesting to pursue. We just have to find a way to make it fit the template. Both your integration and the one for proxmox are interesting. As it is I will have to transfer things over at one point, most likely to your widget as the base. And I will combine those widgets together dynamically. If you've addressed everything in the comments we might be able to merge soon and then you can add dashdot.

hillaliy commented 4 months ago

The last commit includes all comments fix. I want to make some changes so I'll commit it soon

hillaliy commented 4 months ago

New design.

Screenshot 2024-02-17 at 13 44 59 Screenshot 2024-02-17 at 13 45 19 Screenshot 2024-02-17 at 13 45 37
ajnart commented 4 months ago

@hillaliy Is the PR good to go now ? I think we can start resolving the conflict to merge it

hillaliy commented 4 months ago

I think you can merge

hillaliy commented 4 months ago
Screenshot 2024-02-24 at 15 36 37

This is The new disign The updates and reboot will appear only if available / require.

dslatt commented 4 months ago

@hillaliy where are you seeing the cputemp rpc? i don't see it as part of the rpc supported by omv

https://github.com/openmediavault/openmediavault/tree/master/deb/openmediavault/usr/share/openmediavault/engined/rpc

was getting errors when testing on my omv instance

hillaliy commented 4 months ago

You need to install CPU temp from OMV plugins. Can you report that everything works?

dslatt commented 4 months ago

that makes sense. i'm running it as a vm so no actual temp data i'll make the cputemp optional as part of #1903