ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.48k stars 253 forks source link

Media requests widget shows original language rather than the user's #1982

Closed realSZ27 closed 3 months ago

realSZ27 commented 3 months ago

Environment

Docker

Version

0.15.2

Describe the problem

When there are requests for movies that aren't in the user's default language, it will show the original title of the media. Screenshot_20240322_105715_Firefox Here, Spirited Away (A movie) is in Japanese, but Anohana (A show) is in English.

In the code for TV series, it calls series.name, but in movies it specifically calls the movies.originalTitle rather than movies.name. I assume this is just a simple "change originalTitle to name", but I can't test it until later.

I'm also not really sure if this would be a bug or a feature, because everything is working correctly, but it's also not really a new feature.

Logs

Nothing here really. As I said, it's working, but it's also not a new feature.

homarr  | Exporting hostname...
homarr  | Migrating database...
homarr  | yarn run v1.22.19
homarr  | $ ts-node ./migrate.ts
homarr  | Done in 6.14s.
homarr  | Starting production server...
homarr  | Listening on port 7575 url: http://0b5ff79fe1a3:7575

Context

It's also important to note that there is a language query in the Overseerr API, which might allow users in languages other than english to have their language displayed.

I might give this fix a shot (I wouldn't know how to do the language query) when I can since it seems pretty simple, but I can't promise anything.

Overseer API docs

Please tick the boxes

github-actions[bot] commented 3 months ago

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

SeDemal commented 3 months ago

That's an interesting find. I'm guessing they were built differently because sonarr took so long to officially come out in V5, and thus their new API. I'll look into each response to make it more consistent.

SeDemal commented 3 months ago

Nah turns out we really just missed title because it was lower than "originalTitle" and the response is a bit tricky to navigate. Thanks for pointing this out :)