search

ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.48k stars 253 forks source link

OIDC Timeout #2002

Closed catrielmuller closed 2 months ago

catrielmuller commented 2 months ago

Hi Tomas (@ajnart), I have exactly the same issue reported on #1995 , this is a simple fix that can resolve a lot of headaches to the users that want to use OIDC (Because everything can be configured correctly, however if the latency between the service it's not enough will be fail)

Category

Bugfix

Overview

if the OIDC provider don't respond in less than 3500ms (Default NextAuth Implementation) the connection fails between Hommar backend and the OIDC provider.

This PR add a new config parameter to increase the timeout using AUTH_OIDC_TIMEOUT

Issue Number 1995

https://github.com/ajnart/homarr/issues/1995

New Vars (if applicable)

Screenshot (if applicable)

No Applicable

catrielmuller commented 2 months ago

@ajnart I will make that changes this night and only add the changes from this commit -> https://github.com/ajnart/homarr/pull/2002/commits/e19f53ff0871b7f3e416a63934a0a57d8395a63a

catrielmuller commented 2 months ago

@ajnart I clean up this PR and I make another one (https://github.com/homarr-labs/documentation/pull/65) to update the documentation. If you need more help here, we can discuss if at least I can exclude that files on the .gitignore. DevEnv (https://devenv.sh/) it's a really cool way to define reproducible dev environments and it's super useful if anybody pull the project can have a required environment in 5 minutes.

ajnart commented 2 months ago

@ajnart I clean up this PR and I make another one (homarr-labs/documentation#65) to update the documentation. If you need more help here, we can discuss if at least I can exclude that files on the .gitignore. DevEnv (https://devenv.sh/) it's a really cool way to define reproducible dev environments and it's super useful if anybody pull the project can have a required environment in 5 minutes.

I think it's a great idea, but I don't know if many people will use it. You can do a POC PR and we can discuss it there. I'll look at the docs PR now ;)