search

ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.45k stars 252 forks source link

DNS Hole Toggle - Configure Time #2026

Open prizmpaladin opened 2 months ago

prizmpaladin commented 2 months ago

Description

It would be nice if there was a configuration to set the duration that the dns hole is disabled. In pihole this is an additional argument to pihole disable; e.g. pihole disable 30s or pihole disable 10m. I'm not familiar with other dns holes, it may not be similar.

I'm always forgetting to turn it back on so this would be a great quality of life feature for me.

Priority

Low (Nice-to-have)

github-actions[bot] commented 2 months ago

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

dslatt commented 2 months ago

that's a good idea. i'll look into adguard/pihole and see how that could be handled.

hillaliy commented 2 months ago

Hi good idea. @dslatt we can make timer function to handle this.

dslatt commented 2 months ago

it looks like both pihole/adguard support timed disables through their api so we can use that

hillaliy commented 2 months ago

I can handle this if you want. But I still think that timer function is simpler. When you push the disable button a small modal will pop up to enter time. If 0 then unlimited.

dslatt commented 2 months ago

@hillaliy what were you thinking of for the timer function? i'm not sure what you mean by it

i added a duration argument to the dnshole control api stuff here; just uses the 'duration' number to specify how long to disable when calling the pihole/adguard api. I didn't touch the widgets ui yet https://github.com/dslatt/homarr/tree/feature/dns-control-timer

hillaliy commented 2 months ago

OK I'll take a look at it

hillaliy commented 2 months ago

Nice. I'll use it and I'll change the UI. For my opinion I think that the DNSHoleControlers & DNSHoleSummary should be one widget. I will make the changes and make an option to chose for new UI or old UI.

github-actions[bot] commented 5 days ago

Hello 👋, this issue has been open for 60 days without activity. We mark issues to help prioritise and close dead issues. Can you confirm that this issue is still relevant on the latest version? I'll remove the stale label as soon as there is further activity on this issue. Thank you 🙏