search

ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.45k stars 252 forks source link

Fix ldap filters #2033

Closed SeDemal closed 1 month ago

SeDemal commented 2 months ago

Category

Bugfix and feature

Overview

Fix ldap search filter attribute (Hardcoded even though env variable for it where already present, must have been forgotten) Add ldap search extra arguments (for both user search and group search) Add log points to better help the user understand which step is not working.

Issue Number

Discord report

New Vars

AUTH_LDAP_USERNAME_ATTRIBUTE : (Not new but actually implemented now) Attribute to designate the username AUTH_LDAP_USER_MAIL_ATTRIBUTE : Attribute to designate email field (Email being obligatory, we need to be accomodating) AUTH_LDAP_USERNAME_FILTER_EXTRA_ARG : Extra argument for the user search field AUTH_LDAP_GROUP_FILTER_EXTRA_ARG : Extra argument for the user's groups field

SeDemal commented 1 month ago

lgtm, is documentation updated or ready for update?

https://github.com/homarr-labs/documentation/pull/70 It should have everything for this PR and #2023. Latest of the latest commits are bugfixes/behavior improvements so I don't thinks there's a need to change it. It also includes documentation for other ldap/oidc env var that were added in older PR's.

Also to note, this PR was validated by the 2 users about Active directory, but if anyone wants to try their normal ldap environment to see if I didn't break anything, it'd be helpful.