ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.45k stars 252 forks source link

"Open all in new tab" uses internal address rather than external address #2036

Closed Barina closed 1 month ago

Barina commented 1 month ago

Environment

Docker

Version

0.15.2

Describe the problem

Within a board, when clicking on the 3 dots menu > "open all in new tab" of a filled category, all shortcuts (or apps) opened in their own tab using the internal address rather than the external one. (see images below) This causes issues when trying to "open all in new tab" self-hosted services (Docker containers in my case) from a different machine or from the host. No problem when trying to open external websites links such as github.com, homarr.dev etc... The issue is more related for services (or apps) that resides on a server. In my case there are a few services I self-host on my server that have a different internal address.

Logs

Logs are empty.

Context

In my example, there are a few self-hosted services including Nginx Proxy Manager, Portainer, Remotely, AdGuard Home and so on. The below screenshots focuses on only one Nginx Proxy Manager. image image image

Please tick the boxes

github-actions[bot] commented 1 month ago

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

j3lte commented 1 month ago

This should be fixed in v0.15.3, I added this fix our working on the dynamic url feature. Please check it against this last version :)

Barina commented 1 month ago

Oh yes 0.15.3 works like a charm! thanks a lot that was blazing fast considering the new stuff :)