search

ajnart / homarr

Customizable browser's home page to interact with your homeserver's Docker containers (e.g. Sonarr/Radarr)
https://homarr.dev
MIT License
5.45k stars 252 forks source link

Added an option for noreferrer #2048

Open H3phaist0s opened 1 month ago

H3phaist0s commented 1 month ago

Category

Bugfix / Feature

Overview

Added an option to specify if the referrer should be omitted from the request headers for the external URLs.

Issue Number (if applicable)

Related issue: #1933

Screenshot (if applicable)

image

ajnart commented 1 month ago

Actually can you make this default behavior ? (Remove the option and add it by default) Do you agree @manuel-rw

H3phaist0s commented 1 month ago

This should be probably be noted as a separate issue but I just noticed that after updating the PR the review status didn't change. You may want to update your repo settings so people can't push code after a review is complete but before the PR is merged.

Meierschlumpf commented 1 month ago

@H3phaist0s as you've removed the switch you can probably revert also the changes in default.json, add-app.json, shared/app.ts and types/app.ts. As well as removing the check for app.behaviour.noReferrer and just use noreferrer as value for the app tile. At least when I undestand the statement of @ajnart correctly