search

ajnisbet / opentopodata

Open alternative to the Google Elevation API!
https://www.opentopodata.org
MIT License
327 stars 71 forks source link

Include EU-DEM rename script in git repo #18

Closed janusw closed 3 years ago

janusw commented 3 years ago

The renaming script from https://www.opentopodata.org/datasets/eudem/ is very useful for setting up the EU-DEM data for usage with OpenTopoData. It would be even more useful if it was included in the git repo, so that one could directly run it on the server.

The first commit in this PR adds the script to the repo (I'm simply putting it in the base dir, but one could also move it into a new subdir, e.g. util/ or scripts/).

The second commit removes the script from the EU-DEM page and replaces it by a link, in order to avoid duplication. That's kind of optional.

ajnisbet commented 3 years ago

I'd rather leave the script as-is sorry. Basically they're too much work to maintain, and I don't want to have unmaintaned code in the repo.

The renaming and downloading scripts aren't up to the quality of the rest of the codebase: they have hardcoded options that need changing, they might be out of date as dataset naming systems change, they aren't covered by testing, they don't have error checking or documentation, and I just didn't write them particularly well.

My hope is that providing the scripts in text encourages users to copy and read the code to adapt it for their purposes, and signals that it's not a core part of the project.

Thanks for all your help with Open Topo Data recently!