ajnsit / concur-documentation

Documentation for Concur
https://ajnsit.github.io/concur-documentation/
66 stars 10 forks source link

Issue with example code? #14

Closed drewolson closed 4 years ago

drewolson commented 4 years ago

I'm noticing that many examples using onClick (among others) don't compile for me as-in. I'm forced to either add a void or unit <$. For example, the following code doesn't compile:

hello :: forall a. Widget HTML a
hello = do
  button [onClick] [text "Say Hello"]
  button' [text "Hello Sailor!"]

It compiles with these modifications:

hello :: forall a. Widget HTML a
hello = do
  button [void onClick] [text "Say Hello"]
  button' [text "Hello Sailor!"]

Is this expected? If so, should I submit a PR for updating the examples?

ajnsit commented 4 years ago

Closing this as fixed in the corresponding PR.