search

ajnyga / embedGalley

OJS3 plugin for visualizing JATS XML galleys
GNU General Public License v3.0
8 stars 3 forks source link

Fix whitespace problem with binaries (images) #8

Closed asmecher closed 4 years ago

asmecher commented 4 years ago

The OJS 3.1.2 release https://github.com/ajnyga/embedGalley/releases/download/1.0.0.2/embedGalley.tar.gz appears to serve up whitespace at the start of images. Reported here:

https://forum.pkp.sfu.ca/t/do-images-get-corrupted-in-ojs-3-1-2-4/59058

This appears to come from whitespace after closing ?> PHP end tags, e.g. in EmbedGalleyPlugin.inc.php.

I propose removing the PHP end tags.

asmecher commented 4 years ago

(PR: https://github.com/ajnyga/embedGalley/pull/9)

ajnyga commented 4 years ago

thanks alec