search

ajnyga / objectsForReview

GNU General Public License v3.0
1 stars 4 forks source link

Locale and creator #4

Closed CFanselow closed 1 year ago

CFanselow commented 3 years ago

Hi @ajnyga,

  1. in https://github.com/ajnyga/objectsForReview/blob/stable-3-1-2/locale/de_DE/emailTemplates.xml#L14

"en_US" should be changed to "de_DE".

  1. I could not save the data in submission workflow -> metadata. I works if I add

    $objectForReview->setCreator("manager");

to https://github.com/ajnyga/objectsForReview/blob/stable-3-1-2/controllers/grid/form/ObjectsForReviewForm.inc.php#L142

Regards, Carola

ajnyga commented 3 years ago

Hi, is this specifically for 3.1.2?

CFanselow commented 3 years ago

I didn't test it on other versions.

ajnyga commented 1 year ago

These should be all fixed in the latest version, some of it already in the last version