search

ajoberstar / gradle-git

Git plugin for Gradle
Apache License 2.0
561 stars 89 forks source link

Lost commit when running the prepareGhPages and publishGhPages tasks separately #238

Closed rodm closed 7 years ago

rodm commented 7 years ago

I raised issue #221 and after upgrading and I got what I thought was the same problem. Digging into it, it looks like a later change has introduced a new problem but with the same output, the publish task is skipped.

This PR splits the repo function in GithubPagesPlugin into 3 functions that open the repository, verify it matches the configuration and resets the repository to the target branch, with only the prepare task calling the reset function.

ajoberstar commented 7 years ago

Hi @rodm, I've released gradle-git-publish to supersede the org.ajoberstar.github-pages plugin. I'll be formally deprecating this plugin in an upcoming release, and won't be making further changes here.

Can you test the new plugin to see if it still presents the same issue?

rodm commented 7 years ago

@ajoberstar I had tried using it but I got an exception, I've created a new issue for that, gitPublishReset throws exception . Given that gradle-git-publish is only at version 0.1 is it ready to replace the github-pages plugin?

ajoberstar commented 7 years ago

It is 0.1 but it's effectively the same code as has been in gradle-git for 5 years. I wanted to give people a few months to validate that it doesn't have any major API problems before going to 1.0.