ajoberstar / reckon

Infer a project's version from your Git repository.
Apache License 2.0
187 stars 28 forks source link

Cannot release a final or significant stage without a clean repo error even though repo is clean #190

Closed luisgdeita closed 1 year ago

luisgdeita commented 1 year ago

What determines if vcs inventory is clean?

Currently getting the msg error in the title even though the repo is clean, git status does not show any modified/untracked file.

Below a debug log from a local build i attempted. 2022-11-10T17:42:10.381-0800 [DEBUG] [org.ajoberstar.reckon.core.Reckoner] Retrieved the following VCS inventory: VcsInventory[baseNormal=2.21.59,baseVersion=2.21.59,claimedVersions=[here go a bunch of prior versions, 2.21.58, etc],clean=false,commitId=9e93300,commitsSinceBase=34,currentVersion=,parallelNormals=[]] 2022-11-10T17:42:10.385-0800 [DEBUG] [org.ajoberstar.reckon.core.Reckoner] Using provided scope value: PATCH 2022-11-10T17:42:10.390-0800 [DEBUG] [org.ajoberstar.reckon.core.Reckoner] Using final stage.

ajoberstar commented 1 year ago

Reckon relies on JGit, which has some inconsistencies with cli git. Historically, I think the main problems come up with submodules.

Another example of #94 being a good idea to implement.

luisgdeita commented 1 year ago

Managed to find the offending file, it was an auto-generated file we had in our vcs but was being updated by the pipeline, closing this.