Closed ajoberstar closed 6 years ago
ScopeNormalStrategy takes a Supplier<Optional<Scope>> and StagePreReleaseStrategy takes a Supplier<Optional<String>>.
ScopeNormalStrategy
Supplier<Optional<Scope>>
StagePreReleaseStrategy
Supplier<Optional<String>>
These would benefit from using the context generally available to the strategies, so add new constructors:
ScopeNormalStrategy(Function<VcsInventory, Optional<Scope>>)
StragePreReleaseStrategy(BiFunction<VcsInventory, Version, Optional<String>>)
This would enable some things like, based on the target normal look at the corresponding GitHub milestone to tell what stage you're in.
ScopeNormalStrategytakes aSupplier<Optional<Scope>>andStagePreReleaseStrategytakes aSupplier<Optional<String>>.These would benefit from using the context generally available to the strategies, so add new constructors:
ScopeNormalStrategy(Function<VcsInventory, Optional<Scope>>)StragePreReleaseStrategy(BiFunction<VcsInventory, Version, Optional<String>>)This would enable some things like, based on the target normal look at the corresponding GitHub milestone to tell what stage you're in.