ajoberstar / reckon

Infer a project's version from your Git repository.
Apache License 2.0
187 stars 28 forks source link

Expose tag selector function on Reckon builder and extension #99

Closed michelzanini closed 2 years ago

michelzanini commented 6 years ago

The use case here is to be able to recognize other non-standard tags, as for example master-RELEASE-1.0.0, or RELEASE-1.0.0, etc...

This is just a preview to start a discussion, maybe you would like this to be done is some other way.

I have made the simplest possible solution to expose tagSelector to the builder and to the Gradle extension. I understand maybe you don't wish to expose it to the Gradle extension.

There is two other ways I can see a solution for this problem:

Let me know what solution you see more fit, and I can change this PR.

Note: I have not looked at the tests yet as I want to wait until you approve the approach before doing that (but I made sure the test still pass).

Thanks.

ajoberstar commented 2 years ago

Sorry for the delay. Superseded by #171.