search

ajohnson10209 / CodeacademyBuildWebAPICapstone

Capstone project from the course Build Web APIs From Scratch. I completed this course on 3-25-2019
0 stars 0 forks source link

Great Job - API Specs #4

Open cc-prj-review-alf opened 5 years ago

cc-prj-review-alf commented 5 years ago

https://github.com/ajohnson10209/CodeacademyBuildWebAPICapstone/tree/master/capstone-project-2-expresso/api

You did a great job in organizing the route paths and route functions. I'm still on the fence myself on the naming scheme of menuItemRoutes / menuItemMW for example. As, it's not really clear what that 'MW' stands for. If that makes any sense. A pattern like 'menuItemRoutes / menuItemControlle' would also do. However, I won't fault you too much for this one as the code in your statements are mostly well organized.

ajohnson10209 commented 5 years ago

Thanks for the review! The MW stood for Middleware. I was defining all of my middleware functions in that file, exporting them, then mounting them to my routes.