ajoliat23 / blockBook

0 stars 0 forks source link

Solana Wallet Adapter Functionality #23

Closed ajoliat23 closed 1 year ago

ajoliat23 commented 1 year ago

Proposed changes

Wallet connection functionality for phantom, glow, slope, torus, and sollet wallets.

Types of changes

Further comments

It seems like the NFT search components can remain as .js files and still work within the typescript version of our react app, however, if it bothers anyone to have different types of files they can be converted to .tsx, that process will probably be a little time consuming though. Additionally the SolflareWalletAdapter or LedgerWalletAdapters break our app, which is why they are commented out. If these wallet adapters are important and should be included in our app we can look into fixing that bug.

jgurary commented 1 year ago

JS and TS can coexist without issue. You can also add @ts-ignore notations to TS as a "make this work like JS" band-aid when you can't wrangle the type system into doing what you want.

SolflareWalletAdapter and LedgerWalletAdapters are not popular enough to be important for you. Honestly if only Phantom works, that's fine for the purposes of the capstone (and for several major defi teams as well). I believe the wormhole portal was Phantom only for months, even as it had 100mil+ in value sent through it daily!