ajones05 / seearound.me-ionic

0 stars 0 forks source link

Can't progress past "Allow location access" #169

Closed ajones05 closed 7 years ago

ajones05 commented 7 years ago

Two people I shared it with have said they hit the "Allow location access" button and then nothing happens - it never advances to the login page, so they are stuck. One is an iphone 6s, the other is also an iPhone 6 with the latest update: 10.2.1. Can you take a look?

abdulhafeez commented 7 years ago

Are they not getting this alert:

"Failed to get your location. Make sure you are connected to the internet and allowed geolocation on your devivce."

ajones05 commented 7 years ago

*EDIT: I realize the two people having problems are both outside of the area we set, so it is likely related to the location check that was added back to the last version to see if a user is inside or outside the area.

They both said nothing happens. They don't get an error msg. Just nothing happens and they can't advance to the log in screen. One person wrote: "Nothing happens. It sort of blinks to acknowledge that I hit the button but that's it. No other error message. "

Also there's a typo in that: "devivce" has an extra "v" and should be "device"

abdulhafeez commented 7 years ago

Thanks! Thats very important info. I have been looking for other reasons but really, I could not find anything that could cause this kind of issue. Outside the area can be the root cause. I may have missed some scenario while making changes last time. I am going to test it thoroughly now.

abdulhafeez commented 7 years ago

and I have just found the culprit straight away: I missed a service $ionicPopup in Intro Controller which actually shows the popup. Its absence obviously caused an error when the app tried to show popup to tell the user that the app is not available in their area. That was my mistake ... sorry! I have fixed it now.

ajones05 commented 7 years ago

Interestingly one of them sent me this message this morning:

Today I reinstalled it and this time when I clicked on the button the "allow location access?" etc message popped up. I clicked yes but then nothing happened. Clicking the original button again yielded no response. Hm.

abdulhafeez commented 7 years ago

No problem. That is understandable. The OS also asks for location permission when you install first time or after deleting the previous app. The was getting location alright but handling afterwards had the issue which I have fixed.

ajones05 commented 7 years ago

I assume a new build has to be submitted now?

abdulhafeez commented 7 years ago

For this issue, yes. I'll make new builds once you confirm the other FB login issue was fixed.

ajones05 commented 7 years ago

I have a feeling he's not going to test again and I don't want to bug him again... let's just create the new build, unless you have doubts about the fix.

abdulhafeez commented 7 years ago

OK, I have no doubt the fix. Going to make builds.

ajones05 commented 7 years ago

It worked, but I'm told that now "After permitting location services, it now tells me that I will only be shown Oakland. But instead it shows my current location [which is outside of the set area]."

Can we just hard-code the location to "Lake Merritt, Oakland, CA" for anyone outside the boundaries?

abdulhafeez commented 7 years ago

Fixed.