ajones05 / seearound.me-ionic

0 stars 0 forks source link

Search issues #195

Closed ajones05 closed 7 years ago

ajones05 commented 7 years ago
  1. If I enter a search term and then hit "Go," then nothing appears to happen. If I move the map, it no longer changes location. However, if I hit the arrow in lower right to center on my location, then search appears to activate.

  2. "Go" should not work if nothing is entered in search box.

  3. If a user does a search, it should be applied within current filters only. (For example, if only the "development" category is on, then only that category will be searched.)

abdulhafeez commented 7 years ago
  1. @yuriyua can I pass category_id to mobile/myposts API for this purpose? I think this is not implemented yet.
yuriyua commented 7 years ago

@ajones05 1. Should we use category_id as filter (show only selected category posts) or order (like site)?

  1. category_id filter is single or multiple value?
ajones05 commented 7 years ago

@yuriyua

  1. Should we use category_id as filter (show only selected category posts) or order (like site)?

I don't understand, can you explain a little more?

  1. category_id filter is single or multiple value?

Unless I am misunderstanding, each category_id filter should be a single value. @abdulhafeez might have different thoughts, though

abdulhafeez commented 7 years ago
  1. In my opinion, yes, category_id should be used as a filter. We are already passing the parameter named 'filter' on mobile/myposts API. Only the values will change. Yuriyua can use values of the filter param to filter posts on back end.

  2. Obviously, there is no other option than sending multiple values. For example if we have two filters food and events on, we will need to send 1 and 3 as an array parameter like [1, 3]. Only then server side code can filter according to given categories.

abdulhafeez commented 7 years ago

As discussed on upwork, lets leave (3) as it is for now. @yuriyua please don't make any changes to mobile/myposts api.

abdulhafeez commented 7 years ago

I have fixed No. 1

abdulhafeez commented 7 years ago

Also fixed No. 2

yuriyua commented 7 years ago

ok, please let me know if i should make any changes