Open ajones05 opened 7 years ago
ok, I will do it
@abdulhafeez for recent searches
@yuriyua I did not get any data on this so far. The response I get is following: {"status":"SUCCESS"}
There is no data. My guess is that it may be related to other issue I posted. It seems there is some error when you are putting recent searches in the database.
Thanks! it is fixed.
I tried searching. The first search stays under "Recent searches" but any new search terms are never added (so only the first search term continues to be visible)
@yuriyua This seems to be a server side issue.
I removed group query parameter. Could you test it now, please?
Something is still not right. Two things:
The recent search terms seem to multiply
If you scroll down, it ends up going into List view (it should just let you see one page of recent searches, with no duplicates.
I have fixed issue 2. @yuriyua Can you check for issue 1? I don't see anything wrong on my side.
@abdulhafeez yes, I will fix this issue tomorrow
A few issues now:
I don't see any recent searches appear now.
The Recent Searches bar moves everything down (it should just overlay and cover, not move)
After searching, the keyboard should disappear, but right now it stays up.
Should I remove all duplicates from the response or just neighbours duplicates?
Old response:
{
"token": "4HS8KM3I5VR38HCLZI7FCC77C2ISKZIPGCY422M6XF96ZLRY71EIDLQQNBIAA51S"
}
{
"status": "SUCCESS",
"result": [
"Lake",
"Restaurant",
"Restaurant",
"Restaurant",
"Restaurant",
"Restaurant",
"Restaurant",
"Lake",
"Lake",
"Restaurant",
"Restaurant",
"Restaurant"
]
}
Remove neighbours duplicates:
{
"token": "4HS8KM3I5VR38HCLZI7FCC77C2ISKZIPGCY422M6XF96ZLRY71EIDLQQNBIAA51S"
}
{
"status": "SUCCESS",
"result": [
"Lake",
"Restaurant",
"Lake",
"Restaurant"
]
}
Remove all duplicates:
{
"token": "4HS8KM3I5VR38HCLZI7FCC77C2ISKZIPGCY422M6XF96ZLRY71EIDLQQNBIAA51S"
}
{
"status": "SUCCESS",
"result": [
"Lake",
"Restaurant"
]
}
Remove all duplicates (there's no reason to have any)
done
@abdulhafeez 1. The recent searches appear alright but there are still duplicates.
Can you show me request/response example, please?
@yuriyua I tested just now and it seems it has been fixed. No more duplicates now.
Good. Let me know if I can any help you.
They seem to repeat after the end of the list. In this case, it should just be white space after the last three searches. But you see the same three keep repeating
The issue was on my side. Fixed.
@yuriyua can you help with an API to track recent searches? Just the last 8 or 10 searches. This is being added to the search page on the mobile app, like this:![search page](https://user-images.githubusercontent.com/10637288/27804403-95e884da-5fe3-11e7-8169-8f6568ce52e3.png)