ajoslin / angular-scrolly

Fake transform-scrolling with angular-friendly utilities
http://ajoslin.github.io/angular-scrolly
65 stars 7 forks source link

new version is buggy (in Chrome) #12

Closed bugwelle closed 11 years ago

bugwelle commented 11 years ago

Hello, I know that I'm reporting many issue right now, but this one is a bit annoying. :)

I've build the new version (see #11; I commented those lines out) and edited the demo, so it works with Angular 1.1.4 and the new angular-scrolly file (I only edited the script tags).

But now (with dev tools - touch enabled) scrolling is really buggy. When I try to scroll with my mouse (not the mouse wheel), it sometimes scrolls and sometimes it doesn't.

Maybe it's because of the latest commits. I haven't looked into them. I hope someone could help.

Thanks, Andre

ajoslin commented 11 years ago

Scrolling with the mouse on desktop is really unreliable - I wouldn't recommend it really. Just use the mousewheel / arrows / etc.

ajoslin commented 11 years ago

Oh wait, do you mean dragging the scrollbar or dragging the content?

bugwelle commented 11 years ago

I mean dragging the content. I'm testing my mobile app in Chrome ;) I don't mean scrolling with the mouse wheel. That works well. :)

ajoslin commented 11 years ago

OK. Yeah, I dunno how to fix it lol, but I dont think most people would try it really.

bugwelle commented 11 years ago

I'll try it on my mobile device, but last version worked well in Chrome. If I find the reason for that buggy behaviour, I'll let you know ;)

ajoslin commented 11 years ago

OK. I removed the mouse drag events, that's probably why - dragging is touch only now.

bugwelle commented 11 years ago

removing this:

     //Hack taken from iscroll for mouse events
      elm.bind('mouseout', function mouseout(e) {
        e = e.originalEvent || e;
        var t = e.relatedTarget;
        if (!t) { 
          dragEnd(e);
        } else {
          while ( (t = t.parentNode) ) {
            if (t === elm) return;
          }
          dragEnd(e);
        }
      });

from dragger.js fixed this. :)

ajoslin commented 11 years ago

Nice :-)!

ajoslin commented 11 years ago

Fixed in b4daccd9913f2bfc40d37efc4b8b47fd5bbe0787